Skip to content

Fix link to assets#2

Merged
romanlutz merged 1 commit into
mainfrom
romanlutz/assets_link_fix
Jan 11, 2024
Merged

Fix link to assets#2
romanlutz merged 1 commit into
mainfrom
romanlutz/assets_link_fix

Conversation

@romanlutz
Copy link
Copy Markdown
Contributor

The image in the README is currently not rendering. This PR fixes the underlying link.

@github-actions
Copy link
Copy Markdown

Test Results

69 tests  ±0   69 ✅ ±0   16s ⏱️ +3s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit ff1f3b1. ± Comparison against base commit 86ca851.

@romanlutz romanlutz merged commit e923e29 into main Jan 11, 2024
@romanlutz romanlutz deleted the romanlutz/assets_link_fix branch January 11, 2024 17:11
@rdheekonda
Copy link
Copy Markdown
Contributor

There are some broken links in the example/demo/ Jupyter notebooks, specifically in notebooks 2, 3, and 4. Since you're here, could you take a moment to fix these links?

varunj-msft added a commit to varunj-msft/PyRIT that referenced this pull request Apr 4, 2026
adrian-gavrila pushed a commit to adrian-gavrila/PyRIT that referenced this pull request Apr 24, 2026
Bundled response to the remaining reviewer comments on the Attack History
filter-Combobox migration.

microsoft#2/microsoft#3  memory: switch `attack_class` and `targeted_harm_categories`
       deprecations in `MemoryInterface.get_attack_results` to the
       project-standard `print_deprecation_message(removed_in="0.15.0")`
       helper; drop the now-unused `import warnings`. No direct successor
       exists for `targeted_harm_categories`; point users at
       `labels={"harm_category": [...]}` (labels supports OR-within-key).

microsoft#4     memory/backend: make attack-class matching case-insensitive to
       match converter-class matching. Removed the explicit
       `case_sensitive=True` override (default is False in every backend);
       flipped the regression test to assert lower/upper/mixed casing all
       match. Service + route docs updated.

microsoft#5     frontend: refactor `AttackHistory.fetchAttacks` request-params
       builder from a stack of seven conditional object spreads into a
       precomputed, explicitly-guarded `params` object for readability.

microsoft#6     frontend: rename `attackClasses` field, `attackClassOptions` prop,
       `attack-class-filter` testid (and all mirrors) to `attackType*` so
       they track the server-side `attack_types` query param.

microsoft#7     backend: rewrite FastAPI `Query` descriptions for `attack_types`,
       `converter_types`, and `label` to spell out "May be specified
       multiple times" semantics with concrete `?key=v1&key=v2` examples.

microsoft#8     backend: widen `attack_types` / `converter_types` annotations from
       `Optional[list[str]]` to `Optional[Sequence[str]]` (matches the
       already-`Sequence`-typed inner label values).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
varunj-msft added a commit to varunj-msft/PyRIT that referenced this pull request Jun 3, 2026
…es dataset_names

ScenarioRunService._build_init_kwargs() used to construct a plain
DatasetConfiguration whenever the caller passed dataset_names. This
silently lost subclass-specific behavior such as
EncodingDatasetConfiguration.get_all_seed_attack_groups(), which
shapes each seed into a SeedAttackGroup with a synthetic objective.

The downstream symptom for the Encoding scenario was:
  ValueError: SeedAttackGroup must have exactly one objective. Found 0.

raised during attack construction. Reproducible end-to-end against the
real garak_slur_terms_en dataset.

Fix: when dataset_names is supplied, construct a fresh instance of the
scenario's *own* default-dataset-config class so subclass overrides are
preserved. Fall back to the plain DatasetConfiguration (with a logged
warning) if a future subclass adds required __init__ kwargs we cannot
populate.

The max_dataset_size-only path keeps reusing-and-mutating the throwaway
introspection instance's default config (no behavior change).

Tests:
- 5 new regression tests, all of which fail against pre-fix code.
- All 30 existing tests still pass.
- Full backend suite: 619 passed, 4 skipped.
- Full scenario suite: 624 passed.

Refs: US 8380 (Standardizing Scenarios), PR microsoft#2 of 12.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants